Skip to content

Commit

Permalink
polkadot: parachains: Fix v9 host configuration migration (#2103)
Browse files Browse the repository at this point in the history
We shouldn't override with their default fields that have been added in
the previous version(v8), because we are going to lose whatever values have
been set.

Note, v8 & v9 seems to have landed at the same time on Rococo, probably
they will land at the same time on westend and other chains, so functionally
doesn't make much difference, but let's have this fixed for people that copy-paste
:D, like me.

---------

Signed-off-by: Alexandru Gheorghe <[email protected]>
  • Loading branch information
alexggh authored Oct 31, 2023
1 parent ada1ac3 commit 64f4b15
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions polkadot/runtime/parachains/src/configuration/migration/v9.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ use frame_support::{
};
use frame_system::pallet_prelude::BlockNumberFor;
use primitives::{SessionIndex, LEGACY_MIN_BACKING_VOTES};
use sp_runtime::Perbill;
use sp_std::vec::Vec;

use frame_support::traits::OnRuntimeUpgrade;
Expand Down Expand Up @@ -145,11 +144,11 @@ pvf_voting_ttl : pre.pvf_voting_ttl,
minimum_validation_upgrade_delay : pre.minimum_validation_upgrade_delay,
async_backing_params : pre.async_backing_params,
executor_params : pre.executor_params,
on_demand_queue_max_size : 10_000u32,
on_demand_base_fee : 10_000_000u128,
on_demand_fee_variability : Perbill::from_percent(3),
on_demand_target_queue_utilization : Perbill::from_percent(25),
on_demand_ttl : 5u32.into(),
on_demand_queue_max_size : pre.on_demand_queue_max_size,
on_demand_base_fee : pre.on_demand_base_fee,
on_demand_fee_variability : pre.on_demand_fee_variability,
on_demand_target_queue_utilization : pre.on_demand_target_queue_utilization,
on_demand_ttl : pre.on_demand_ttl,
minimum_backing_votes : LEGACY_MIN_BACKING_VOTES
}
};
Expand Down

0 comments on commit 64f4b15

Please sign in to comment.