Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Don't allocate in expect_valid_rlp unless necessary #8867

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Don't allocate in expect_valid_rlp unless necessary #8867

merged 2 commits into from
Jun 12, 2018

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented Jun 11, 2018

expect_valid_rlp is used quite often in terms of number of allocations (27.8%):
heaptrack

@ordian ordian added A0-pleasereview 🤓 Pull request needs code review. B0-patchthis M4-core ⛓ Core client code / Rust. labels Jun 11, 2018
@parity-cla-bot
Copy link

It looks like @ordian signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

ascjones
ascjones approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad!

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 12, 2018
@debris debris merged commit 2a470de into openethereum:master Jun 12, 2018
@ordian ordian deleted the reduce_memory_allocations branch June 12, 2018 08:50
dvdplm added a commit that referenced this pull request Jun 12, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
4d733bc 
* master:
  Tx permission contract improvement (#8400)
  Limit the number of transactions in pending set (#8777)
  Use sealing.enabled to emit eth_mining information (#8844)
  Don't allocate in expect_valid_rlp unless necessary (#8867)
  Fix Cli Return Code on --help for ethkey, ethstore & whisper (#8863)
@5chdn 5chdn added this to the 1.12 milestone Jun 13, 2018
tavakyan referenced this pull request in C4Coin/c4coin-parity Jun 14, 2018
@ordian @tavakyan
Don't allocate in expect_valid_rlp unless necessary (#8867)
0bca81b 
* don't allocate via format! in case there's no error

* fix test?
@5chdn 5chdn mentioned this pull request Jun 18, 2018
Closed
57 tasks
andresilva pushed a commit that referenced this pull request Jun 18, 2018
@ordian @andresilva
Don't allocate in expect_valid_rlp unless necessary (#8867)
d8d2792 
* don't allocate via format! in case there's no error

* fix test?
@andresilva andresilva mentioned this pull request Jun 18, 2018
Merged
18 tasks
5chdn pushed a commit that referenced this pull request Jun 19, 2018
@andresilva @5chdn
[beta] Backports (#8916)
cc44ae9 
* `duration_ns: u64 -> duration: Duration` (#8457)

* duration_ns: u64 -> duration: Duration

* format on millis {:.2} -> {}

* Keep all enacted blocks notify in order (#8524)

* Keep all enacted blocks notify in order

* Collect is unnecessary

* Update ChainNotify to use ChainRouteType

* Fix all ethcore fn defs

* Wrap the type within ChainRoute

* Fix private-tx and sync api

* Fix secret_store API

* Fix updater API

* Fix rpc api

* Fix informant api

* Eagerly cache enacted/retracted and remove contain_enacted/retracted

* Fix indent

* tests: should use full expr form for struct constructor

* Use into_enacted_retracted to further avoid copy

* typo: not a function

* rpc/tests: ChainRoute -> ChainRoute::new

* Handle removed logs in filter changes and add geth compatibility field (#8796)

* Add removed geth compatibility field in log

* Fix mocked tests

* Add field block hash in PollFilter

* Store last block hash info for log filters

* Implement canon route

* Use canon logs for fetching reorg logs

Light client removed logs fetching is disabled. It looks expensive.

* Make sure removed flag is set

* Address grumbles

* Fixed AuthorityRound deadlock on shutdown, closes #8088 (#8803)

* CI: Fix docker tags (#8822)

* scripts: enable docker builds for beta and stable

* scripts: docker latest should be beta not master

* scripts: docker latest is master

* ethcore: fix ancient block error msg handling (#8832)

* Disable parallel verification and skip verifiying already imported txs. (#8834)

* Reject transactions that are already in pool without verifying them.

* Avoid verifying already imported transactions.

* Fix concurrent access to signer queue (#8854)

* Fix concurrent access to signer queue

* Put request back to the queue if confirmation failed

* typo: fix docs and rename functions to be more specific

`request_notify` does not need to be public, and it's renamed to `notify_result`.
`notify` is renamed to `notify_message`.

* Change trace info "Transaction" -> "Request"

* Don't allocate in expect_valid_rlp unless necessary (#8867)

* don't allocate via format! in case there's no error

* fix test?

* fixed ipc leak, closes #8774 (#8876)

* Add new ovh bootnodes and fix port for foundation bootnode 3.2 (#8886)

* Add new ovh bootnodes and fix port for foundation bootnode 3.2

* Remove old bootnodes.

* Remove duplicate 1118980bf48b0a3640bdba04e0fe78b1add18e1cd99bf22d53daac1fd9972ad650df52176e7c7d89d1114cfef2bc23a2959aa54998a46afcf7d91809f0855082

* Block 0 is valid in queries (#8891)

Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762

* Add ETC Cooperative-run load balanced parity node (#8892)

* Minor fix in chain supplier and light provider (#8906)

* fix chain supplier increment

* fix light provider block_headers

* Check whether we need resealing in miner and unwrap has_account in account_provider (#8853)

* Remove unused Result wrap in has_account

* Check whether we need to reseal for external transactions

* Fix reference to has_account interface

* typo: missing )

* Refactor duplicates to prepare_and_update_sealing

* Fix build

* Allow disabling local-by-default for transactions with new config entry (#8882)

* Add tx_queue_allow_unknown_local config option

- Previous commit messages:

dispatcher checks if we have the sender account

Add `tx_queue_allow_unknown_local` to MinerOptions

Add `tx_queue_allow_unknown_local` to config

fix order in MinerOptions to match Configuration

add cli flag for tx_queue_allow_unknown_local

Update refs to `tx_queue_allow_unknown_local`

Add tx_queue_allow_unknown_local to config test

revert changes to dispatcher

Move tx_queue_allow_unknown_local to `import_own_transaction`

Fix var name

if statement should return the values

derp de derp derp derp semicolons

Reset dispatch file to how it was before

fix compile issues + change from FLAG to ARG

add test and use `into`

import MinerOptions, clone the secret

Fix tests?

Compiler/linter issues fixed

Fix linter msg - case of constants

IT LIVES

refactor to omit yucky explict return

update comments

Fix based on diff AccountProvider.has_account method

* Refactor flag name + don't change import_own_tx behaviour

fix arg name

Note: force commit to try and get gitlab tests working again 😠

* Add fn to TestMinerService

* Avoid race condition from trusted sources

- refactor the miner tests a bit to cut down on code reuse
- add `trusted` param to dispatch_transaction and import_claimed_local_transaction

Add param to `import_claimed_local_transaction`

Fix fn sig in tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier rphmeier approved these changes

@debris debris debris approved these changes

@ascjones ascjones ascjones approved these changes

@folsen folsen folsen approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.
7 participants
@ordian @parity-cla-bot @folsen @ascjones @debris @rphmeier @5chdn