Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

use atty instead of isatty #8365

Merged
merged 1 commit into from
Apr 11, 2018
Merged

use atty instead of isatty #8365

merged 1 commit into from
Apr 11, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Apr 11, 2018 •
edited
Loading

  • clap uses atty
  • isatty is not updated to winapi 0.3

so this reduces number of our dependencies

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Apr 11, 2018
andresilva
andresilva approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andresilva andresilva merged commit dd2c279 into master Apr 11, 2018
@debris debris deleted the atty branch April 11, 2018 11:45
@5chdn 5chdn added this to the 1.11 milestone Apr 11, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @andresilva @5chdn