This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove InvalidParentHash in favor of assert! #8300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sorpaas
changed the title
sorpaas
changed the title
|
Okay I think this is fixed now. I should have asserted a true case, but instead asserted false. |
debris
approved these changes
Apr 4, 2018
debris
added
A8-looksgood 🦄
andresilva
approved these changes
Apr 5, 2018
…move-invalid-parent-hash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the TODO item states (and I manually checked),
InvalidParentHasherror if happens, indicate a codebase bug. (Only used inverify_parentand parent is always fetched locally.)So here we remove InvalidParentHash and use an assert! instead.