Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Revert "ci: disable link-dead-code in coverage build (#8118)" #8287

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

andresilva
Copy link
Contributor

This reverts commit 4d1cb01.

#8118 (comment)

This will break the coverage build but at least it won't report an erroneous coverage percentage.

@andresilva andresilva added the M1-ci 🙉 Continuous integration. label Apr 2, 2018
@andresilva andresilva added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A0-pleasereview 🤓 Pull request needs code review. labels Apr 2, 2018
Copy link
Contributor

@General-Beck General-Beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave this option

@General-Beck General-Beck merged commit 54c9c38 into master Apr 2, 2018
@General-Beck General-Beck deleted the andre-revert-fix-coverage-build branch April 2, 2018 13:06
@5chdn 5chdn added this to the 1.11 milestone Apr 3, 2018
@5chdn
Copy link
Contributor

5chdn commented Apr 25, 2018

What are we doing with this now? Hoping it will be fixed in Rust?

@andresilva
Copy link
Contributor Author

There are two crates that break the compiler with link-dead-code (only one shows up in the build logs):

  • futures-timer - I plan on refactoring parity-reactor to use the new tokio Runtime (https://tokio.rs/blog/2018-03-tokio-runtime/). This will give us more efficient global timers and we can then drop the futures-timer dependency.
  • patricia-trie - I tested and this is fixed with Rust 1.26 (which should be released in a couple of weeks).

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M1-ci 🙉 Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants