This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Return null number for pending block in eth_getBlockByNumber #8281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @sorpaas signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
tomusdrw
reviewed
Mar 31, 2018
| @@ -230,7 +230,10 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM, T: StateInfo + 'static> EthClient<C, SN, S | |||
| state_root: view.state_root().into(), | |||
| transactions_root: view.transactions_root().into(), | |||
| receipts_root: view.receipts_root().into(), | |||
| number: Some(view.number().into()), | |||
There was a problem hiding this comment.
According to the same spec hash should be null as well.
rpc/src/v1/impls/eth.rs
Outdated
| @@ -180,9 +180,9 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM, T: StateInfo + 'static> EthClient<C, SN, S | |||
| fn rich_block(&self, id: BlockNumberOrId, include_txs: bool) -> Result<Option<RichBlock>> { | |||
| let client = &self.client; | |||
|
|
|||
| let client_query = |id| (client.block(id), client.block_total_difficulty(id), client.block_extra_info(id)); | |||
| let client_query = |id, is_pending| (client.block(id), client.block_total_difficulty(id), client.block_extra_info(id), is_pending); | |||
There was a problem hiding this comment.
Just inline false here, no point to pass is_pending
|
According to the spec, |
tomusdrw
approved these changes
Mar 31, 2018
tomusdrw
added
A8-looksgood 🦄
KronicDeth
added a commit
to blockscout/blockscout
that referenced
this pull request
Jul 31, 2018
Fixes #490 Compatibility with openethereum/parity-ethereum#8281, which fixed openethereum/parity-ethereum#8028 and made pending return be compliant with Ethereum docs.
feliperenan
pushed a commit
to blockscout/blockscout
that referenced
this pull request
Aug 1, 2018
Fixes #490 Compatibility with openethereum/parity-ethereum#8281, which fixed openethereum/parity-ethereum#8028 and made pending return be compliant with Ethereum docs.
KronicDeth
added a commit
to blockscout/blockscout
that referenced
this pull request
Aug 1, 2018
Fixes #490 Compatibility with openethereum/parity-ethereum#8281, which fixed openethereum/parity-ethereum#8028 and made pending return be compliant with Ethereum docs.
alexgaribay
pushed a commit
to blockscout/blockscout
that referenced
this pull request
Aug 2, 2018
Fixes #490 Compatibility with openethereum/parity-ethereum#8281, which fixed openethereum/parity-ethereum#8028 and made pending return be compliant with Ethereum docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8028
Check whether it's fetching the pending block. If so, write the block number as null in JSONRPC.