Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update app_dirs to 1.2.1 #8268

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Update app_dirs to 1.2.1 #8268

merged 2 commits into from
Mar 30, 2018

Conversation

rleungx
Copy link
Contributor

@rleungx rleungx commented Mar 30, 2018 •
edited
Loading

This PR fixes the compiling error with rustc 1.25.0.
app_dirs2 is a fork of app_dirs and it seems that app_dirs is no longer maintained.
See #8267.

@parity-cla-bot
Copy link

It looks like @rleungx hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@rleungx
Copy link
Contributor Author

rleungx commented Mar 30, 2018

[clabot:check]

@parity-cla-bot
Copy link

It looks like @rleungx signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@tomusdrw
Copy link
Collaborator

image

Seems that the author woke up, maybe better to just bump the version then?

@rleungx
Copy link
Contributor Author

rleungx commented Mar 30, 2018

Sure. I didn't notice that.

@rleungx rleungx changed the title replace app_dirs with app_dirs2 Update app_dirs to 1.2.1 Mar 30, 2018
tomusdrw
tomusdrw approved these changes Mar 30, 2018
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rleungx ! LGTM

@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. labels Mar 30, 2018
@niklasad1 niklasad1 merged commit 443115f into openethereum:master Mar 30, 2018
@greysteil
Copy link

greysteil commented Mar 30, 2018 •
edited
Loading

Would you be up for automatically generating dependency update PRs like this one (well, without all the work to handle breaking changes)? I built Dependabot to try and help people keep their dependencies up-to-date, and just added Rust support. When I ran it on my fork it generated these PRs.

It's totally free for open source, and always will be - I'm just looking for beta testers and advice. :octocat:

@5chdn 5chdn added this to the 1.11 milestone Apr 3, 2018
@5chdn 5chdn added the M5-dependencies 🖇 Dependencies. label Apr 5, 2018
@i1skn i1skn mentioned this pull request May 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging this pull request may close these issues.
6 participants
@rleungx @parity-cla-bot @tomusdrw @greysteil @niklasad1 @5chdn