Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Updated jsonrpc to include latest backports (1.9) #8182

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

kirushik
Copy link
Collaborator

No description provided.

@kirushik kirushik added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Mar 21, 2018
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 21, 2018
@kirushik kirushik removed the request for review from debris March 21, 2018 18:21
@debris
Copy link
Collaborator

debris commented Mar 22, 2018

@paritytech/ci it looks like we have a problem with #6507 again

@debris debris added the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Mar 22, 2018
@5chdn 5chdn added this to the Patch milestone Mar 22, 2018
@niklasad1
Copy link
Collaborator

niklasad1 commented Mar 23, 2018

But this error looks actually like there are multiple versions of jsonrpc installed:

Compiling jsonrpc-http-server v8.0.0 (https://github.com/paritytech/jsonrpc.git?branch=parity-1.9#e23a96cb)

Update:
It looks like a CI is caching some old references because when I run it looks ok:

$ cargo tree | grep parity-1.9

@twittner
Copy link
Contributor

twittner commented Mar 23, 2018

@niklasad1: If I am not mistaken, there are actually some dependency updates missing, e.g. hyper version >= 0.11.20. I am in the process of getting those updates in. Cf. #8180, #8181.

- `jsonrpc` PR #244 required `hyper >= 0.11.20` which in turn required
updating `tokio-core`, `mio` and `iovec`.

- `jsonrpc` PR #246 required updating `https://github.com/tomusdrw/ws-rs`.
@tomusdrw tomusdrw merged commit d40d9e1 into stable Mar 23, 2018
@tomusdrw tomusdrw deleted the kirushik/update_jsonrpc_1_9 branch March 23, 2018 13:32
@5chdn 5chdn removed the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants