This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
SecretStore: get rid of engine.signer dependency #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
svyatonik
added
A3-inprogress ⏳
|
Also fixed 2 small issues, found while testing:
|
svyatonik
added
A0-pleasereview 🤓
svyatonik
added
A0-pleasereview 🤓
svyatonik
added
A4-gotissues 💥
svyatonik
added
A0-pleasereview 🤓
rphmeier
reviewed
Apr 9, 2018
secret_store/src/trusted_client.rs
Outdated
| /// Transact contract. | ||
| pub fn transact_contract(&self, contract: Address, tx_data: Bytes) -> Result<(), Error> { | ||
| let client = self.client.upgrade().ok_or(Error::Internal("cannot submit tx when client is offline".into()))?; | ||
| let miner = self.miner.upgrade().ok_or(Error::Internal("cannot submit tx when miner is offline".into()))?; |
There was a problem hiding this comment.
ok_or_else would prevent unconditional allocations of the errors messages.
5chdn
added
A1-onice 🌨
rphmeier
added
A8-looksgood 🦄
debris
approved these changes
Apr 9, 2018
svyatonik
added a commit
that referenced
this pull request
Apr 18, 2018
* SecretStore: get rid of engine.signer dependency * SecretStore: fixed self for transact_contract * SecretStore: fixed pending requests + 1-of-1 sessions completion * SecretStore: fixed completion signal in 1-of-1 case * fixed test(s) * removed obsolete TODO && redundant statement * ok_or -> ok_or_else
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was assumed that in PoA networks KeyServers will only be running on authority nodes && both
engine.signerandsecretstore.self_secretwill be the same. This is PR to get rid of this requirement && that's how KS will be initially deployed on Kovan (not on authority nodes).