This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
optional dependency on secp256k1 for ethcrypto #8109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
|
LGTM, but could we also add a readme in this folder for what's in this crate and why you would want to use what feature? I.E. "By default you can do this, if you enable this feature you can also do that" |
debris
approved these changes
Mar 19, 2018
General-Beck
added a commit
that referenced
this pull request
Mar 19, 2018
This reverts commit 249f81c.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot of this crypto code is more generally useful even without an secp256k1 dependency