This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix comment for gas extern in Wasm runtime #8101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexfrl
added
A0-pleasereview 🤓
lexfrl
force-pushed
the
wasm-fix-comment-for-gas
branch
from
879f9b7 to
5bfd705
Compare
|
New comment is wrong, this external is not only about block of execution, it is general gas charge; so please revert to previous or update to something with complete meaning |
|
@NikVolf |
|
Previous comment was at least correct. For example, grow_memory also is charged via |
|
let’s just make a pull request to extend/fix the comment. The problem with the previous version was that it confuses user and not clarifies the actual purpose of the extern |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.