Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ethcore-service #8089

Merged
merged 4 commits into from
Mar 13, 2018
Merged

ethcore-service #8089

merged 4 commits into from
Mar 13, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 12, 2018

based on #8086

changes:

  • ClientService moved to new crate ethcore-service
  • ClientIoMessage moved to client module

reason:

I did it to simplify relationship between service, client and private_transactions from #6422 . In #6422 all messages from service are going through client and there is no need for it.

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 12, 2018
@debris debris requested review from andresilva and 0x7CFE March 12, 2018 16:51
andresilva
andresilva approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@debris debris merged commit de72643 into master Mar 13, 2018
@debris debris deleted the separate_service branch March 13, 2018 10:50
@5chdn 5chdn added this to the 1.11 milestone Mar 20, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@0x7CFE 0x7CFE Awaiting requested review from 0x7CFE

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @andresilva @5chdn