This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
structured rlp encoding in journaldb #8047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
andresilva
reviewed
Mar 15, 2018
| }).expect("Low-level database error.") { | ||
| let rlp = Rlp::new(&rlp_data); | ||
| let inserts: Vec<H256> = rlp.list_at(1); | ||
| //let mut index = 0usize; |
| } | ||
|
|
||
| impl<'a> DatabaseValueView<'a> { | ||
| pub fn new(data: &'a [u8]) -> Self { |
There was a problem hiding this comment.
I think it would be better to rename this to something like from_rlp?
|
Guess I was too late but I had a pending review for this. Just minor stuff though. |
|
Too quick on the draw - I can make those changes if okay with @debris |
General-Beck
added a commit
that referenced
this pull request
Mar 19, 2018
This reverts commit 21cb085.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of #8033, I'm trying to get rid of all usages of
Rlp. This pr get rids of unsafe usages ofRlpinjournaldb. To reduce the number of calls toexpect()I introduced structured encoding in the module.