Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[beta] Wallet allowJsEval: true #7913

Merged
merged 3 commits into from
Feb 16, 2018
Merged

[beta] Wallet allowJsEval: true #7913

merged 3 commits into from
Feb 16, 2018

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Feb 16, 2018

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. A8-backport 🕸 Pull request is already reviewed well in another branch. M7-ui labels Feb 16, 2018
@amaury1093
Copy link
Contributor

Just played with this branch, Contract -> Develop works well.

dapp-console has unsafe-eval error as expected (for now).

amaury1093
amaury1093 approved these changes Feb 16, 2018
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contract develop & Dapp console both working now.

@5chdn 5chdn merged commit acef56b into beta Feb 16, 2018
@5chdn
Copy link
Contributor

5chdn commented Feb 16, 2018

Thanks!

@5chdn 5chdn deleted the jg-unsafe branch February 16, 2018 13:33
@5chdn 5chdn added this to the Patch milestone Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review. A8-backport 🕸 Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
Patch
Development

Successfully merging this pull request may close these issues.
4 participants
@jacogr @amaury1093 @5chdn @tomusdrw