Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Show all accounts on Topbar #7498

Merged
merged 4 commits into from
Jan 8, 2018
Merged

Show all accounts on Topbar #7498

merged 4 commits into from
Jan 8, 2018

Conversation

amaury1093
Copy link
Contributor

  • The topbar account selector used to only show accounts from parity_getNewDappsAddresses. Now we show all of them.
  • The updated js-shared also removes dapp-dapp-accounts, whose functionalities are 100% replaced by the topbar account selector.

@amaury1093 amaury1093 added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 8, 2018
@5chdn 5chdn added this to the 1.9 milestone Jan 8, 2018
@amaury1093 amaury1093 added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 8, 2018
@amaury1093 amaury1093 added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jan 8, 2018
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 8, 2018
@jacogr jacogr merged commit c6b0db6 into master Jan 8, 2018
@jacogr jacogr deleted the am-topbar-accounts branch January 8, 2018 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.
3 participants
@amaury1093 @jacogr @5chdn