Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Store tokens with repeatable id #7435

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Store tokens with repeatable id #7435

merged 1 commit into from
Jan 3, 2018

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 3, 2018 •
edited
Loading

Closes #7194

Instead of trying to get rid of the token (which is then changed by the stored value), -

  1. Store the tokens with a non-changeable id
  2. On invalid tokens, set the address to empty
  3. empty addresses are not queried for balances

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 3, 2018
@jacogr jacogr closed this Jan 3, 2018
@jacogr jacogr removed the A0-pleasereview 🤓 Pull request needs code review. label Jan 3, 2018
@jacogr jacogr reopened this Jan 3, 2018
@jacogr jacogr added the A0-pleasereview 🤓 Pull request needs code review. label Jan 3, 2018
@5chdn 5chdn added this to the 1.9 milestone Jan 3, 2018
@5chdn 5chdn added the P5-sometimesoon 🌲 Issue is worth doing soon. label Jan 3, 2018
@amaury1093 amaury1093 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 3, 2018
@jacogr jacogr merged commit 7c1cbd3 into master Jan 3, 2018
@jacogr jacogr deleted the jg-tokens-cache branch January 3, 2018 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.
3 participants
@jacogr @amaury1093 @5chdn