This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix wallet token/badge icons not showing up #7333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
reviewed
Dec 19, 2017
| @@ -19,7 +19,7 @@ import { connect } from 'react-redux'; | |||
|
|
|||
| import { hashToImageUrl } from '~/redux/providers/imagesReducer'; | |||
|
|
|||
| import defaultIcon from '../../../assets/images/certifications/unknown.svg'; | |||
| import defaultIcon from '~/../assets/images/certifications/unknown.svg'; | |||
There was a problem hiding this comment.
1st time I see this syntax, didn't know it existed. ~ represents the root right? I.e. where package.json is?
There was a problem hiding this comment.
In this case, it is the source root. It is a webpack alias - beats the ../../.. stuff that otherwise just litters the code.
amaury1093
reviewed
Dec 19, 2017
| const { image, token } = this.props; | ||
|
|
||
| if (!token.native) { | ||
| console.log('token', token); |
There was a problem hiding this comment.
Is this console.log needed?
There was a problem hiding this comment.
Thanks. Searched, thought I removed it.
amaury1093
approved these changes
Dec 19, 2017
amaury1093
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7324