This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
SecretStore: return error 404 when there's no key shares for given key on all nodes #7331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Dec 21, 2017
| @@ -227,7 +227,7 @@ impl<T> SessionImpl<T> where T: SessionTransport { | |||
| // try to complete session | |||
| Self::try_complete(&self.core, &mut *data); | |||
| if no_confirmations_required && data.state != SessionState::Finished { | |||
| return Err(Error::ConsensusUnreachable); | |||
There was a problem hiding this comment.
What's the reason for this change? Can you elaborate?
There was a problem hiding this comment.
Do you mean this particular line? It's initialize method which is called on the 'session master' node. no_confirmations_required means that there are no other nodes in the SecretStore (i.e. SS consists of the single KeyServer && we are on this KeyServer). Since we haven't found key share for given key on this key server (state != SessionState::Finished) => this means that key haven't been generated at all => we need to return MissingKeyShare.
MissingKeyShare in turn is converted to the 404 HTTP error later
tomusdrw
added
A6-mustntgrumble 💦
svyatonik
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
debris
approved these changes
Dec 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same behavior was there before
KeyVersionNegotiationSessionwas introduced: return HTTP 404 error when trying to restore the key before it was generated.By @grbIzl requrest