Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix inject.js & Signer store duplication #7299

Merged
merged 2 commits into from
Dec 15, 2017
Merged

Fix inject.js & Signer store duplication #7299

merged 2 commits into from
Dec 15, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 15, 2017

No description provided.

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 15, 2017
@amaury1093
Copy link
Contributor

Yes, fixes both issues!

Just one small comment, I have a "The prop date is marked as required in Request, but its value is undefined"

@amaury1093
Copy link
Contributor

Will fix in paritytech/js-ui#28

@amaury1093 amaury1093 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 15, 2017
@jacogr jacogr merged commit 509038c into master Dec 15, 2017
@jacogr jacogr deleted the jg-fixes branch December 15, 2017 16:52
@5chdn 5chdn added this to the 1.9 milestone Jan 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants