This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Rework dapps list #7206
Merged
Rework dapps list #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
reviewed
Dec 6, 2017
| app={ app } | ||
| availability={ availability } | ||
| className={ styles.dapp } | ||
| key={ `${index}_${app.id}` } |
There was a problem hiding this comment.
Wouldn't app.id be enough?
There was a problem hiding this comment.
Yes, overkill (as I typed it that thought came to mind)
There was a problem hiding this comment.
Actually no. Just "fixed", the "reverted" as I remembered why I took this longer route.
When I have the app as both a local app (linked from dapps) as well as an app of the network, the ids are the same. (It was not an issue previously since they were in separate lists)
amaury1093
reviewed
Dec 6, 2017
js/src/Dapps/dapps.js
Outdated
| @@ -48,6 +46,7 @@ class Dapps extends Component { | |||
| } | |||
|
|
|||
| render () { | |||
| const { availability } = this.props; | |||
| let externalOverlay = null; | |||
|
|
|||
| if (this.store.externalOverlayVisible) { | |||
There was a problem hiding this comment.
We could use a ? : operator here for externalOverlay
amaury1093
approved these changes
Dec 6, 2017
amaury1093
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A start, there is more that can be done, provides a springboard for more cleanups.