This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Make Signing Requests more visible #7204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @amaurymartiny signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
jacogr
reviewed
Dec 5, 2017
| <div className={ [styles.signerPending].join(' ') }> | ||
| <Icon name={ this.store.pending.length > 0 ? 'bell' : 'bell outline' } /> | ||
| {this.store.pending.length > 0 && | ||
| <Label floating color='red' size='mini' circular className={ styles.label }> |
There was a problem hiding this comment.
Can we keep to an attribute per-line?
jacogr
reviewed
Dec 5, 2017
| size='mini' | ||
| /> | ||
| </List.Content> | ||
| <Image avatar size='mini' verticalAlign='middle'> |
There was a problem hiding this comment.
As above, attribute per line
jacogr
reviewed
Dec 5, 2017
| this.setState({ isOpen: false }); | ||
| } | ||
|
|
||
| renderEtherValue (value) { |
There was a problem hiding this comment.
This probably makes sense as a smaller component? (I know we have render* methods all-over, but it is a bit of something that says "this really should be a component"
jacogr
reviewed
Dec 5, 2017
| } | ||
| </List> | ||
| ) : ( | ||
| <Container textAlign='center' fluid className={ styles.noRequest }> |
jacogr
reviewed
Dec 5, 2017
|
|
||
| render () { | ||
| return ( | ||
| <Popup |
There was a problem hiding this comment.
Generally this whole render is quite a beast - probably makes sense to try and condense it, maybe split at least the content bits (where we have a ?:) into seperate components?
jacogr
added
A3-inprogress ⏳
|
amaury1093
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7192. Red label was not comprehensible to drive users to action, so introducing a more classic notification UX.
"View" button opens the Signer as before.