Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixed ethstore-cli output #7052

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Fixed ethstore-cli output #7052

merged 1 commit into from
Nov 14, 2017

Conversation

svyatonik
Copy link
Collaborator

Before fix:

svyatonik@xwnotebook:~/dev/parity.testss$ ./ethstore insert 834cb736f02d9c968dfaf0c37658a1d86ff140554fc8b59c9fdad5a8cf810eec password --dir db.dev_ss1/keys/DevelopmentChain/
0xStoreAccountRef { address: 261e9dbf51fe9f8b7339269940ac08124de8d557, vault: Root }

After fix:

svyatonik@xwnotebook:~/dev/parity.testss$ ./ethstore insert 834cb736f02d9c968dfaf0c37658a1d86ff140554fc8b59c9fdad5a8cf810eec password --dir db.dev_ss1/keys/DevelopmentChain/
0x261e9dbf51fe9f8b7339269940ac08124de8d557

Looks like it was broken since vaults introduction.

@svyatonik svyatonik added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 14, 2017
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Nov 14, 2017
@tomusdrw
Copy link
Collaborator

tomusdrw commented Nov 14, 2017

No build? CC @paritytech/ci

@5chdn 5chdn added this to the 1.9 milestone Nov 14, 2017
@debris debris merged commit cc184d5 into master Nov 14, 2017
@debris debris deleted the fix_ethstore_cli_output branch November 14, 2017 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants