This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Adds personal_signTransaction RPC method
#6991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
suggested changes
Nov 6, 2017
rpc/src/v1/impls/personal.rs
Outdated
| Ok(default) => default, | ||
| Err(e) => return Box::new(future::err(e)), | ||
| }; | ||
| fn sign_transaction(&self, meta: Metadata, request: TransactionRequest, password: String) -> BoxFuture<RpcH256, Error> { |
There was a problem hiding this comment.
You need to get whole RichRawTransaction, just the hash is not useful at all. The whole point of this RPC method is to get signed RLP (raw transaction) that you will be able to propagate later.
tomusdrw
added
A4-gotissues 💥
|
The tests should go to |
0x7CFE
added
A0-pleasereview 🤓
0x7CFE
force-pushed
the
personal_sign_transaction
branch
from
d164f92 to
6b932d1
Compare
debris
approved these changes
Nov 12, 2017
debris
added
A8-looksgood 🦄
tomusdrw
reviewed
Nov 12, 2017
|
|
||
| let response = r#"{"jsonrpc":"2.0","error":{"code":-32021,"message":"Account password is invalid or account does not exist.","data":"SStore(InvalidPassword)"},"id":1}"#; | ||
|
|
||
| assert_eq!(tester.io.handle_request_sync(request.as_ref()), Some(response.into())); | ||
| } | ||
|
|
||
| #[test] | ||
| fn sign_transaction_with_invalid_password() { |
There was a problem hiding this comment.
Would be nice to have a positive test case as well.
There was a problem hiding this comment.
Don't sure how to check if the response is actually valid.
Is there a convenient way to validate the whole JSON response, knowing that it should describe a transaction? I.e. all fields should exist and types should be correct? Maybe I could try to deserialize it?
There was a problem hiding this comment.
Yeah, deserializing it makes sense.
debris
added
A5-grumble 🔥
0x7CFE
force-pushed
the
personal_sign_transaction
branch
from
6b932d1 to
c607a26
Compare
0x7CFE
force-pushed
the
personal_sign_transaction
branch
from
c607a26 to
b208a10
Compare
tomusdrw
approved these changes
Dec 19, 2017
tomusdrw
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New RPC method
personal_signTransactionis added. Existingsend_transaction's impl is refactored to reuse the common logic.@tomusdrw, I believe I need to write some tests for this. Where should I host them?