This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix #6228: do not display eth price in cli for etc #6877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behaviour: When the client is started with defaults, the miner's gas calibrator periodically queries the price of ether in usd and uses it to adjust the wei_per_gas variable, displaying an info message in the cli each time calibration happens. The info message mentions the price of ETH. When started with the --min-gas-price option, the calibrator is inactive and the price is not displayed. Problem: When running on an alternate chain such as ethereum classic, the info message mentioning the ETH price is present, unless the --min-gas-price option is used. Solution: if chain != foundation and --min-gas-price is not set, don't use GasPricerConfig::Calibrated as default but rather fix the minimum gas price to zero.
|
It looks like @nicolasochem signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
5chdn
added
A0-pleasereview 🤓
arkpar
reviewed
Oct 24, 2017
parity/configuration.rs
Outdated
| @@ -649,6 +649,8 @@ impl Configuration { | |||
| return Ok(GasPricerConfig::Fixed(to_u256(dec)?)); | |||
| } else if let Some(dec) = self.args.arg_min_gas_price { | |||
| return Ok(GasPricerConfig::Fixed(U256::from(dec))); | |||
| } else if self.args.arg_chain != "foundation" { | |||
| return Ok(GasPricerConfig::Fixed(U256::zero())); | |||
There was a problem hiding this comment.
Should be something like
if !Spec_type::from_str(self.chain()).map_or(false, |s| s == SpecType::Foundation)
because there are other strings that match the foundation chain.
There was a problem hiding this comment.
Might be worth to wait for #6878 (or integrate same changes) where self.chain() returns a SpecType
arkpar
added
A4-gotissues 💥
5chdn
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
tomusdrw
approved these changes
Oct 25, 2017
|
Closes #6228 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour:
When the client is started with defaults, the miner's gas calibrator
periodically queries the price of ether in usd and uses it to adjust
the wei_per_gas variable, displaying an info message in the cli each
time calibration happens. The info message mentions the price of ETH.
When started with the --min-gas-price option, the calibrator is inactive
and the price is not displayed.
Problem:
When running on an alternate chain such as ethereum classic, the info
message mentioning the ETH price is present, unless the --min-gas-price
option is used.
Solution:
if chain != foundation and --min-gas-price is not set,
don't use GasPricerConfig::Calibrated as default but rather fix
the minimum gas price to zero.