Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Refresh cached tokens based on registry info & random balances #6818

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Refresh cached tokens based on registry info & random balances #6818

merged 2 commits into from
Oct 19, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Oct 18, 2017

No description provided.

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Oct 18, 2017
@5chdn 5chdn added this to the Patch milestone Oct 18, 2017
@5chdn 5chdn mentioned this pull request Oct 19, 2017
Merged
1 task
ngotchac
ngotchac reviewed Oct 19, 2017
View reviewed changes
Copy link
Contributor

@ngotchac ngotchac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only thing is that currently it fetches balances for every single token, even those which are not used. On further optimisation would be to check if a token is correct only when it's used in the UI (in an account, a contract, whatever.).

@ngotchac ngotchac added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 19, 2017
@jacogr
Copy link
Contributor Author

jacogr commented Oct 19, 2017

@ngotchac Thank you. As discussed, leaving that one for UI-2 where we need to do a lot of further optimisations.

@jacogr jacogr merged commit fdbf6bf into master Oct 19, 2017
@jacogr jacogr deleted the jg-tokens branch October 19, 2017 12:18
jacogr added a commit that referenced this pull request Oct 19, 2017
@jacogr
Refresh cached tokens based on registry info & random balances (#6818)
58b982c 
* Refresh cached tokens based on registry info & random balances

* Don't display errored token images
arkpar pushed a commit that referenced this pull request Oct 19, 2017
@jacogr @arkpar
Refresh cached tokens based on registry info & random balances (#6818) (
284fc65 
#6824)

* Refresh cached tokens based on registry info & random balances

* Don't display errored token images
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ngotchac ngotchac ngotchac left review comments

Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Milestone
Patch
Development

Successfully merging this pull request may close these issues.
3 participants
@jacogr @ngotchac @5chdn