Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Refactors journaldb as a separate crate #6801

Merged
merged 7 commits into from
Oct 18, 2017
Merged

Conversation

0x7CFE
Copy link
Contributor

@0x7CFE 0x7CFE commented Oct 17, 2017

Affects #6693.

  • Refactors journaldb as a separate crate
  • Refactors ethcore and parity to use it instead of util

Note: need to check for now redundant dependencies in .tomls.

@0x7CFE 0x7CFE added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 17, 2017
@0x7CFE 0x7CFE requested review from debris and arkpar October 17, 2017 04:52
@0x7CFE 0x7CFE added this to the 1.9 milestone Oct 17, 2017
@0x7CFE 0x7CFE added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 17, 2017
@0x7CFE
Copy link
Contributor Author

0x7CFE commented Oct 17, 2017

As far as I see, remaining issues are in the tests only https://gitlab.parity.io/parity/parity/-/jobs/67430

However, along with issues, introduced by my refactoring, I see other stuff like keccak, ethcore_logger, kvdb_memorydb and so on. Looks like some previuos refactoring broke dependencies as well.

@0x7CFE 0x7CFE added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 17, 2017
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 18, 2017
@debris debris merged commit 5281e09 into master Oct 18, 2017
@debris debris deleted the refactoring/journal-6693 branch October 18, 2017 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants