This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixed RETURNDATA size for built-ins #6652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
arkpar
added
A3-inprogress ⏳
arkpar
force-pushed
the
returndatasize-builtin-fix
branch
from
786caf3 to
6a1eea1
Compare
arkpar
added
A0-pleasereview 🤓
arkpar
force-pushed
the
returndatasize-builtin-fix
branch
from
5876297 to
6a1eea1
Compare
5chdn
added
the
P2-asap 🌊
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built-ins in some cases overwrite only a portion of the output memory slice. E.g. ecrecover on invalid signature. RETURNDATASIZE needs to hold the size that has been actually written in such cases.