Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

remove RPC parameter leniency now that mist formats correctly #6651

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Oct 5, 2017

Closes #6648

In particular:

  • accepting decimal-formatted block numbers
  • parsing the empty string as empty bytes.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust. labels Oct 5, 2017
@rphmeier rphmeier requested a review from tomusdrw October 5, 2017 15:54
@rphmeier
Copy link
Contributor Author

rphmeier commented Oct 5, 2017

(worth backporting?)

@debris
Copy link
Collaborator

debris commented Oct 5, 2017

It's better not to backport it. I expect some applications to depend on parity misbehaviour. It's better to wait till 1.9 with it

@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 5, 2017
@arkpar arkpar added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Oct 6, 2017
@5chdn 5chdn added this to the 1.9 milestone Oct 6, 2017
@5chdn 5chdn removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Oct 12, 2017
@arkpar arkpar merged commit a2d9b6f into master Oct 12, 2017
@arkpar arkpar deleted the remove-rpc-leniency branch October 12, 2017 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants