This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix extension detection #6452
Merged
Fix extension detection #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
commented
Sep 4, 2017
| @@ -22,6 +22,7 @@ | |||
| height: 100%; | |||
| position: relative; | |||
| width: 100%; | |||
| max-width: 100%; | |||
There was a problem hiding this comment.
This fixes display of accounts on firefox (especially in Parity Bar when selecting default account, the accounts were overlapping).
gavofyork
added
A7-looksgoodtestsfail 🤖
tomusdrw
added
A0-pleasereview 🤓
jacogr
reviewed
Sep 13, 2017
| @@ -60,19 +60,27 @@ export default class Store { | |||
| } | |||
|
|
|||
| @action testInstall = () => { | |||
| this.shouldInstall = this.readStatus(); | |||
| this.readStatus() | |||
There was a problem hiding this comment.
MobX sometimes does things a bit funny when dealing with promises, i.e. not firing updates when inside a promise chain. Generally it would be preferable to...
@action setInstallStatus = (shouldInstall) => {
this.shouldInstall = shouldInstall;
}
testInstall = () => {
this.readStatus().then(this.setInstallStatus);
}
jacogr
reviewed
Sep 13, 2017
|
Thanks @jacogr! Updated. |
jacogr
added
A8-looksgood 🦄
|
LG happy to merge, however Rust tests failing (not that there were any changes there). Something weird is going on. |
jacogr
added
A8-looksgood 🦄
tomusdrw
added a commit
that referenced
this pull request
Sep 15, 2017
* Fix extension detection. * Fix mobx quirks. * Update submodule.
gavofyork
pushed a commit
that referenced
this pull request
Sep 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the extension script is injected a little bit late, so we need to defer the check.
Resolves #6388