Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Wasm storage read test #6255

Merged
merged 4 commits into from
Aug 9, 2017
Merged

Wasm storage read test #6255

merged 4 commits into from
Aug 9, 2017

Conversation

lexfrl
Copy link
Contributor

@lexfrl lexfrl commented Aug 8, 2017

No description provided.

@lexfrl lexfrl requested a review from NikVolf August 8, 2017 10:21
@lexfrl lexfrl added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Aug 8, 2017
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 8, 2017
ext.store.insert("0100000000000000000000000000000000000000000000000000000000000000".into(), address.into());

let (gas_left, result) = {
let mut interpreter = wasm_interpreter();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why two tabs here?

@NikVolf NikVolf added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Aug 8, 2017
@lexfrl lexfrl added A0-pleasereview 🤓 Pull request needs code review. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. A0-pleasereview 🤓 Pull request needs code review. labels Aug 8, 2017
@lexfrl lexfrl added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Aug 8, 2017
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 8, 2017
@arkpar arkpar merged commit d209100 into master Aug 9, 2017
@arkpar arkpar deleted the wasm_storage_read branch August 9, 2017 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants