-
Notifications
You must be signed in to change notification settings - Fork 1.7k
first run: skip account creation if they already have accounts #3827
Conversation
Changes Unknown when pulling b980e7a on jr-first-run into ** on master**. |
they should click through the license whatever; skip button should only be there after that. |
@gavofyork It is the case. The "skip" button is shown in the "create an account" step. |
]; | ||
if (hasAccounts) { | ||
buttons.unshift( | ||
<Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have preferred the labels/hint/text changes into FormattedMessage
while we are in the component. (Saves work later, especially when adding new features).
Not a crisis here though, so will just comment on it - small enough change overall.
Additional prop verification issues introduced:
&
|
This should only be because there's still Edit: can you confirm? |
Changes Unknown when pulling bbcae3d on jr-first-run into ** on master**. |
Yes, you are right, it is a once-off |
This PR addresses #3583 by adding a simple "skip" button to the first run modal, if the user has one or more accounts.