Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

SignedTransaction structure #350

Merged
merged 5 commits into from
Feb 5, 2016
Merged

SignedTransaction structure #350

merged 5 commits into from
Feb 5, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Feb 4, 2016

changes:

  • removed r,s,v and caches from transaction. It simplifies construction of structure
  • Transaction's sign method returns new type SignedTransaction.

closes #307

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Feb 4, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 5, 2016
gavofyork
gavofyork reviewed Feb 5, 2016
View reviewed changes
ethcore/src/transaction.rs
Ok(sender.as_ref().unwrap().clone())
}
}
pub fn message_hash(&self) -> H256 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can now be rightly called hash, since the object no longer contains a signature.

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Feb 5, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. A8-looksgood 🦄 Pull request is reviewed well. labels Feb 5, 2016
@gavofyork
Copy link
Contributor

also rename SignedTransaction::transaction -> SignedTransaction::unsigned, then tx.unsigned.hash actually makes sense when read; tx.transaction.hash doesn't really make sense.

@debris
Copy link
Collaborator Author

debris commented Feb 5, 2016

ok 👍

@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Feb 5, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 5, 2016
debris added a commit that referenced this pull request Feb 5, 2016
@debris
Merge pull request #350 from ethcore/signed_transaction
720c280 
SignedTransaction structure
@debris debris merged commit 720c280 into master Feb 5, 2016
@debris debris deleted the signed_transaction branch February 8, 2016 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Immutable Transaction data structure
3 participants
@debris @gavofyork @NikVolf