This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixes for 1.4 #3260
Merged
Fixes for 1.4 #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #3258 |
tomusdrw
added
A8-looksgood 🦄
gavofyork
added
B7-releasenotes 📜
arkpar
reviewed
Nov 8, 2016
| @@ -562,7 +578,7 @@ | |||
| <key>OVERWRITE_PERMISSIONS</key> | |||
| <false/> | |||
| <key>VERSION</key> | |||
| <string>1.4</string> | |||
| <string>1.5.0</string> | |||
There was a problem hiding this comment.
We aren't releasing 1.5 for some time, so it's either wrong or I misunderstand the purpose of this key
There was a problem hiding this comment.
Should it be changed back to 1.4.1 when backporting?
|
suggest getting this reviewed, merged and 1.4.1 out asap. |
arkpar
reviewed
Nov 8, 2016
| @@ -548,7 +548,7 @@ impl Configuration { | |||
| apis: { | |||
| let mut apis = self.args.flag_ipcapi.clone().unwrap_or(self.args.flag_ipc_apis.clone()); | |||
| if self.args.flag_geth { | |||
| apis.push_str("personal"); | |||
| apis.push_str(",personal"); | |||
There was a problem hiding this comment.
what if apis is empty? E.g. someone disabled all the APIs but still running with --geth because of other compatibility issues
There was a problem hiding this comment.
Seems this was addressed above but not here?
This was referenced Nov 8, 2016
rphmeier
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Nov 8, 2016
* Fix --geth * Fix mac installer. * Fix up installer. * Additional tweaks. * Fix for empty APIs * Another case of empty apis
arkpar
pushed a commit
that referenced
this pull request
Nov 8, 2016
* Fix --geth * Fix mac installer. * Fix up installer. * Additional tweaks. * Fix for empty APIs * Another case of empty apis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installer now comes with uninstall script.