This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Exposing engine extra info in block RPC #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
gavofyork
reviewed
Nov 4, 2016
| @@ -1195,6 +1195,10 @@ impl MiningBlockChainClient for Client { | |||
| self.engine.schedule(&self.latest_env_info()) | |||
| } | |||
|
|
|||
| fn engine(&self) -> &Engine { | |||
There was a problem hiding this comment.
i'd prefer not to expose a complex type like Engine over the BlockChainClient trait; it opens up too much functionality over the interface and destroys the possibility of IPC.
that's why i explicitly stated a proxy function for extra_info.
gavofyork
reviewed
Nov 4, 2016
| uncles: vec![], | ||
| transactions: BlockTransactions::Hashes(vec![].into()), | ||
| size: Some(69.into()), | ||
| }; | ||
|
|
||
| let serialized = serde_json::to_string(&block).unwrap(); | ||
| assert_eq!(serialized, r#"{"hash":"0x0000000000000000000000000000000000000000000000000000000000000000","parentHash":"0x0000000000000000000000000000000000000000000000000000000000000000","sha3Uncles":"0x0000000000000000000000000000000000000000000000000000000000000000","author":"0x0000000000000000000000000000000000000000","miner":"0x0000000000000000000000000000000000000000","stateRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","transactionsRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","receiptsRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","number":"0x0","gasUsed":"0x0","gasLimit":"0x0","extraData":"0x","logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","timestamp":"0x0","difficulty":"0x0","totalDifficulty":"0x0","sealFields":["0x","0x"],"uncles":[],"transactions":[],"size":"0x45"}"#); | ||
| assert_eq!(serialized, r#"{"hash":"0x0000000000000000000000000000000000000000000000000000000000000000","parentHash":"0x0000000000000000000000000000000000000000000000000000000000000000","sha3Uncles":"0x0000000000000000000000000000000000000000000000000000000000000000","author":"0x0000000000000000000000000000000000000000","miner":"0x0000000000000000000000000000000000000000","stateRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","transactionsRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","receiptsRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","number":"0x0","gasUsed":"0x0","gasLimit":"0x0","extraData":"0x","logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","timestamp":"0x0","difficulty":"0x0","totalDifficulty":"0x0","sealFields":["0x","0x"],"extraInfo":{"mixHash":"0x0000000000000000000000000000000000000000000000000000000000000000","nonce":"0x0000000000000000"},"uncles":[],"transactions":[],"size":"0x45"}"#); |
There was a problem hiding this comment.
as i pointed out in the issue, the point of extra_info is that the keys are placed directly into the block/header JSON object. this is required in order to be compatible with the existing geth behaviour.
i went to quite some effort in the original issue describing why this was going to be such a pain.
gavofyork
added
A4-gotissues 💥
tomusdrw
added
A0-pleasereview 🤓
|
Fixed. Sorry for the issues, I've misunderstood the solution you proposed. |
gavofyork
added
A8-looksgood 🦄
|
all good. |
arkpar
pushed a commit
that referenced
this pull request
Nov 4, 2016
* Exposing extra info in RPC * Proper serialization and client trait API
arkpar
added a commit
that referenced
this pull request
Nov 4, 2016
* sendRawTransaction invalid RLP error * Returning proper error for estimate_gas * Exposing engine extra info in block RPC (#3169) * Exposing extra info in RPC * Proper serialization and client trait API * Fixing possible race condition in ethcore_hashContent (#3191) * Remove dapp logos (GHH points to dapp-assets) (#3192)
|
Great! When will this land in the beta-release Docker image? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #3148