This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
eth_checkTransaction renamed to eth_checkRequest #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomusdrw
commented
Aug 3, 2016
tomusdrw
commented
- Some tests added and more specific error
added 12 commits
July 26, 2016 11:44
Conflicts: rpc/src/v1/impls/eth_signing.rs rpc/src/v1/tests/mocked/eth_signing.rs rpc/src/v1/traits/eth.rs
| @@ -143,18 +143,18 @@ impl<C, M> EthSigning for EthSigningQueueClient<C, M> | |||
| }) | |||
| } | |||
|
|
|||
| fn check_transaction(&self, params: Params) -> Result<Value, Error> { | |||
There was a problem hiding this comment.
just check_request? the additional adjective doesn't add much.
[ci:skip]
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.