This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
JournalDB inject #1806
Merged
JournalDB inject #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let (key, (value, rc)) = i; | ||
| if rc > 0 { | ||
| assert!(rc == 1); | ||
| batch.put(self.column, &key, &value).expect("Low-level database error. Some issue with your hard disk?"); |
There was a problem hiding this comment.
not sending this out through UtilError?
gavofyork
added
A6-mustntgrumble 💦
rphmeier
added
A0-pleasereview 🤓
| } | ||
| if rc < 0 { | ||
| assert!(rc == -1); | ||
| if try!(self.backing.get(self.column, &key)).is_none() { |
There was a problem hiding this comment.
these checks probably will slow down inject quite a bit and it's not as though these are going to cause rocksdb errors. are they even worthwhile?
seems like we are using the DB to point out logic errors in the rest of our code.
There was a problem hiding this comment.
yup - this way it fails fast rather than allows an inconsistent situation to persevere.
however, we might consider a build flag (perhaps called "final"?) which allows these checks to be omitted.
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More generic approach to assist snapshot restoration.