This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Supporting eth_sign in Signer #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 26, 2016 11:44
tomusdrw
added
the
A3-inprogress ⏳
tomusdrw
changed the title
added 3 commits
August 1, 2016 20:54
tomusdrw
added
A0-pleasereview 🤓
Closed
|
would have been nicer if the UI integration could have been reviewed in the same PR as the code behind it. instead we just get to "review" some anonymous hashes. |
| fn check_transaction(&self, _: Params) -> Result<Value, Error>; | ||
|
|
||
| /// Should be used to convert object to io delegate. | ||
| fn to_delegate(self) -> IoDelegate<Self> { | ||
| let mut delegate = IoDelegate::new(Arc::new(self)); | ||
| delegate.add_method("eth_sign", EthSigning::sign); | ||
| delegate.add_method("eth_postSign", EthSigning::post_sign); | ||
| delegate.add_method("eth_sendTransaction", EthSigning::send_transaction); | ||
| delegate.add_method("eth_postTransaction", EthSigning::post_transaction); | ||
| delegate.add_method("eth_checkTransaction", EthSigning::check_transaction); |
There was a problem hiding this comment.
checkRequest instead of checkTransaction?
There was a problem hiding this comment.
Yup, I wasn't sure if it's ok to break backward compatibility (and I suppose one of your dapps was using this method).
There was a problem hiding this comment.
fair enough (though another reason to have these parity/ethcore JS extensions in the same repo).
gavofyork
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1419
Closes #1310
Yet to do:
eth_postSign(?) - support async queries for sign (similar toeth_postTransaction)