Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

dynamic keys pickup #1779

Merged
merged 1 commit into from
Jul 31, 2016
Merged

dynamic keys pickup #1779

merged 1 commit into from
Jul 31, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 31, 2016

No description provided.

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Jul 31, 2016
@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 86.878% when pulling 489722b on dynamic_keys_pickup into 9e5e57f on master.

@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 86.768% when pulling 489722b on dynamic_keys_pickup into 9e5e57f on master.

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 31, 2016
@NikVolf NikVolf merged commit f19b00b into master Jul 31, 2016
@arkpar
Copy link
Collaborator

arkpar commented Jul 31, 2016

This can be done properly by watching file system notifications on the dir and updating list immediatelly

@debris debris deleted the dynamic_keys_pickup branch August 1, 2016 10:09
@tomusdrw tomusdrw mentioned this pull request Aug 2, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@debris @coveralls @arkpar @NikVolf @rphmeier