Various improvements to tracing & diagnostics. #1707

gavofyork · 2016-07-24T15:38:08Z

Manage possibility of Account not having code for PodAccount
New RPC: trace_sendRawTransaction
See raw transaction dump when inspecting over RPC

- Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC

coveralls · 2016-07-24T22:40:53Z

Coverage increased (+0.06%) to 75.598% when pulling b59eb60 on additional-rpc-helpers into a76981a on master.

tomusdrw · 2016-07-25T07:36:06Z

ethcore/src/account.rs

-			code_hash: Some(pod.code.sha3()),
-			code_cache: pod.code,
+			code_hash: Some(pod.code.as_ref().map_or_else(|| { warn!("POD account with unknown code is being created! Assuming no code."); SHA3_EMPTY.clone() }, |c| c.sha3())),
+			code_cache: pod.code.as_ref().map_or_else(|| { warn!("POD account with unknown code is being created! Assuming no code."); vec![] }, |c| c.clone()),


It will always display both warnings, maybe worth extracting the warnings somewhere above?

coveralls · 2016-07-25T11:59:11Z

Coverage decreased (-0.006%) to 75.527% when pulling 3232e58 on additional-rpc-helpers into a76981a on master.

arkpar · 2016-07-26T08:02:30Z

rpc/src/v1/traits/traces.rs

@@ -35,6 +35,9 @@ pub trait Traces: Sized + Send + Sync + 'static {
 	/// Executes the given call and returns a number of possible traces for it.
 	fn call(&self, _: Params) -> Result<Value, Error>;

+	/// Executes the given raw transaction and returns a number of possible traces for it.
+	fn send_raw_transaction(&self, _: Params) -> Result<Value, Error>;


It does not actually send the transaction, does it? Perhaps trace_raw_transaction would be a better name

[ci:skip]

coveralls · 2016-07-26T10:49:27Z

Coverage increased (+11.6%) to 87.152% when pulling d7f76d4 on additional-rpc-helpers into a76981a on master.

rphmeier · 2016-07-26T10:50:11Z

ethcore/src/pod_account.rs

@@ -58,14 +58,15 @@ impl PodAccount {
 		stream.append(&self.nonce);
 		stream.append(&self.balance);
 		stream.append(&sec_trie_root(self.storage.iter().map(|(k, v)| (k.to_vec(), encode(&U256::from(v.as_slice())).to_vec())).collect()));
-		stream.append(&self.code.sha3());
+		stream.append(&self.code.as_ref().unwrap_or(&vec![]).sha3());


&[] also works

edit: or should, but the Encodable interface is a little off in what types it accepts...

* Various improvements to tracing & diagnostics. - Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC * Fix test * Remove one of the dupe error messages * Remove unneeded `&`s * Reformat and extremely minor optimisation * Minor optimisation * Remove unneeded let * Fix tests. * Additional fix. * Minor rename. [ci:skip] * Bowing to the pressure.

* Various improvements to tracing & diagnostics. - Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC * Fix test * Remove one of the dupe error messages * Remove unneeded `&`s * Reformat and extremely minor optimisation * Minor optimisation * Remove unneeded let * Fix tests. * Additional fix. * Minor rename. * Bowing to the pressure.

* Don't try to sync to ancient blocks * Parallel block body download * Fixed reading chunked EIP8 handshake (#1712) * Fixed reading chunked EIP8 handshake * Added missing break * Disconnect peers on a fork * Updated json-ipc-server * Combine mining queue and enabled into single locked datum (#1749) * Combine mining queue and enabled into single locked datum Additional tracing. * Fix bug uncovered by test. * Fix typo * Remove unneeded log initialisation in test. * fix failing test (#1756) * Fixed test * Suicides tracing (#1688) * tracing suicide * fixed #1635 * fixed typo * Stackoverflow #1686 (#1698) * flat trace serialization * tracing finds transaction which creates contract * flatten traces before inserting them to the db * Trace other types of calls (#1727) * Trace through DELEGATECALL and CALLCODE Add them to the JSON output and RLP database store. * Fix tests. * Fix all tests. * Fix one more test. * filtering transactions toAddress includes contract creation (#1697) * tracing finds transaction which creates contract * comma cleanup Remove when following `}`s, add to final entries. * Various improvements to tracing & diagnostics. (#1707) * Various improvements to tracing & diagnostics. - Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC * Fix test * Remove one of the dupe error messages * Remove unneeded `&`s * Reformat and extremely minor optimisation * Minor optimisation * Remove unneeded let * Fix tests. * Additional fix. * Minor rename. * Bowing to the pressure. * Stackoverflow fix (#1742) * executive tracer builds flat traces without intermediate struct * temporarilt commented out tests for traces * fixed new way of building trace address * fixed new way of building trace address * updating state tests with flat tracing in progress * fixed flat tracing tests * fixed compiling ethcore-rpc with new flat traces * removed warnings from ethcore module * remove unused data structures

* Suicides tracing (#1688) * tracing suicide * fixed #1635 * fixed typo * Stackoverflow #1686 (#1698) * flat trace serialization * tracing finds transaction which creates contract * flatten traces before inserting them to the db * Trace other types of calls (#1727) * Trace through DELEGATECALL and CALLCODE Add them to the JSON output and RLP database store. * Fix tests. * Fix all tests. * Fix one more test. * filtering transactions toAddress includes contract creation (#1697) * tracing finds transaction which creates contract * comma cleanup Remove when following `}`s, add to final entries. * Various improvements to tracing & diagnostics. (#1707) * Various improvements to tracing & diagnostics. - Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC * Fix test * Remove one of the dupe error messages * Remove unneeded `&`s * Reformat and extremely minor optimisation * Minor optimisation * Remove unneeded let * Fix tests. * Additional fix. * Minor rename. [ci:skip] * Bowing to the pressure. * Stackoverflow fix (#1742) * executive tracer builds flat traces without intermediate struct * temporarilt commented out tests for traces * fixed new way of building trace address * fixed new way of building trace address * updating state tests with flat tracing in progress * fixed flat tracing tests * fixed compiling ethcore-rpc with new flat traces * removed warnings from ethcore module * remove unused data structures

Various improvements to tracing & diagnostics.

c097786

- Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC

gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Jul 24, 2016

Fix test

b59eb60

tomusdrw reviewed Jul 25, 2016
View reviewed changes

tomusdrw added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 25, 2016

gavofyork added 5 commits July 25, 2016 10:13

Remove one of the dupe error messages

6ce475c

Remove unneeded &s

388269d

Reformat and extremely minor optimisation

121836d

Minor optimisation

8c64692

Remove unneeded let

904679c

gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jul 25, 2016

gavofyork added 2 commits July 25, 2016 10:52

Fix tests.

909b044

Additional fix.

3232e58

arkpar reviewed Jul 26, 2016
View reviewed changes

arkpar added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 26, 2016

Minor rename.

f0e418e

[ci:skip]

gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Jul 26, 2016

gavofyork removed the A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. label Jul 26, 2016

arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 26, 2016

debris added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jul 26, 2016

Bowing to the pressure.

d7f76d4

gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Jul 26, 2016

rphmeier reviewed Jul 26, 2016
View reviewed changes

tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 26, 2016

gavofyork merged commit 7cf807d into master Jul 26, 2016

gavofyork deleted the additional-rpc-helpers branch July 26, 2016 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various improvements to tracing & diagnostics. #1707

Various improvements to tracing & diagnostics. #1707

gavofyork commented Jul 24, 2016

coveralls commented Jul 24, 2016 •

edited

Loading

tomusdrw Jul 25, 2016

coveralls commented Jul 25, 2016 •

edited

Loading

arkpar Jul 26, 2016

coveralls commented Jul 26, 2016 •

edited

Loading

rphmeier Jul 26, 2016 •

edited

Loading

Various improvements to tracing & diagnostics. #1707

Various improvements to tracing & diagnostics. #1707

Conversation

gavofyork commented Jul 24, 2016

coveralls commented Jul 24, 2016 • edited Loading

tomusdrw Jul 25, 2016

Choose a reason for hiding this comment

coveralls commented Jul 25, 2016 • edited Loading

arkpar Jul 26, 2016

Choose a reason for hiding this comment

coveralls commented Jul 26, 2016 • edited Loading

rphmeier Jul 26, 2016 • edited Loading

Choose a reason for hiding this comment

coveralls commented Jul 24, 2016 •

edited

Loading

coveralls commented Jul 25, 2016 •

edited

Loading

coveralls commented Jul 26, 2016 •

edited

Loading

rphmeier Jul 26, 2016 •

edited

Loading