Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Ethereum classic #1706

Merged
merged 5 commits into from
Jul 25, 2016
Merged

Ethereum classic #1706

merged 5 commits into from
Jul 25, 2016

Conversation

gavofyork
Copy link
Contributor

No description provided.

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Jul 24, 2016
@coveralls
Copy link

coveralls commented Jul 24, 2016

Coverage Status

Coverage decreased (-0.08%) to 75.455% when pulling 2e3ccf3 on ethereum-classic into a76981a on master.

@aakilfernandes
Copy link

Thanks for this Gav. Could we have classic sync to a different chaindir? A lot of users would likely like to run both chains.

@gavofyork
Copy link
Contributor Author

No sooner said...

@coveralls
Copy link

coveralls commented Jul 24, 2016

Coverage Status

Coverage increased (+0.07%) to 75.599% when pulling 1649022 on ethereum-classic into a76981a on master.

let mut dir = path.to_path_buf();
dir.push(H64::from(genesis_hash).hex());
dir.push(format!("{:?}{}", H64::from(genesis_hash), if let Some(n) = fork_name { format!("-{}", n) } else { "".into() }));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fork_name.map(|f| format!("-{}", f)).unwrap_or_default() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@tomusdrw tomusdrw added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 25, 2016
@gavofyork gavofyork merged commit e734810 into master Jul 25, 2016
@gavofyork gavofyork deleted the ethereum-classic branch July 25, 2016 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants