Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Using streamlined parity-ui repository #1566

Merged
merged 7 commits into from
Jul 12, 2016
Merged

Using streamlined parity-ui repository #1566

merged 7 commits into from
Jul 12, 2016

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Jul 8, 2016

  1. All UI code (Rust + JS) is now in single repository: https://github.com/ethcore/parity-ui
  2. Building Parity now requires Node.js.

If everything will go well with this approach, we may merge parity-ui repo to main repo in the (near) future.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Jul 8, 2016
@gavofyork
Copy link
Contributor

Windows failing?

     Running `C:\projects\parity-g802m\target\release\build\parity-dapps-status-c341dadc6fc516d8\build-script-build`
error: failed to run custom build command for `parity-dapps-status v0.5.1 (https://github.com/ethcore/parity-ui.git#b0c1fa6c)`
Process didn't exit successfully: `C:\projects\parity-g802m\target\release\build\parity-dapps-status-c341dadc6fc516d8\build-script-build` (exit code: 101)
--- stderr
thread '<main>' panicked at 'Error: Installing dependencies: Error { repr: Os { code: 2, message: "The system cannot find the file specified." } }', C:\projects\parity-g802m\target\release\build\parity-dapps-4797a3edb18c7ec7\out/lib.rs:450
note: Run with `RUST_BACKTRACE=1` for a backtrace

@gavofyork gavofyork added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 11, 2016
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Jul 12, 2016
@tomusdrw
Copy link
Collaborator Author

Fixed

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 12, 2016
@rphmeier rphmeier merged commit b37cecc into master Jul 12, 2016
@debris debris mentioned this pull request Jul 12, 2016
4 tasks
@tomusdrw tomusdrw deleted the streamlined-ui branch July 13, 2016 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants