This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Allow configuration of when to reseal blocks. #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-inprogress ⏳
- Optional limit for the amount of gas transactions may have; - option to restruct transactions returned/queried to only those which have been executed.
| _ => { | ||
| queue.top_transactions() | ||
| } | ||
| let sw = self.sealing_work.lock().unwrap(); |
There was a problem hiding this comment.
anyone know if this is the correct order for the lock? (it's the same as before, so should be good...)
gavofyork
added
A0-pleasereview 🤓
This was referenced Jun 27, 2016
Also Move the gas limit into the transaction queue from the miner.
[ci:skip]
|
Looks good to me. @tomusdrw should take a look |
| }; | ||
| match (&self.options.pending_set, sealing_set) { | ||
| (&PendingSet::AlwaysQueue, _) | (&PendingSet::SealingOrElseQueue, None) => queue.pending_hashes(), | ||
| (_, sealing) => sealing.map(|s| s.transactions().iter().map(|t| t.hash()).collect()).unwrap_or(Vec::new()), |
There was a problem hiding this comment.
sealing.map_or_else(Vec::new, |s| ...)
tomusdrw
added
A5-grumble 🔥
|
needs rebase |
tomusdrw
added
A8-looksgood 🦄
| } | ||
|
|
||
| /// Create new instance of this Queue with specified limits | ||
| pub fn with_limit(limit: usize) -> Self { | ||
| pub fn with_limits(limit: usize, tx_gas_limit: U256) -> Self { |
There was a problem hiding this comment.
Sorry to complain again, but maybe removing it from constructor would be good too? No strong feelings though.
There was a problem hiding this comment.
It's changed by setter anyway, other stuff like minimal_gas_price,gas_limit,etc is not here also (because there are sensible defaults / it's unbounded without negative consequences)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.