This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Replace deprecated hashdb trait names #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @keorn hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io Once you've signed, plesae reply to this thread with Many thanks, Ethcore CLA Bot |
|
[clabot:check] |
|
It looks like @keorn signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
| @@ -109,7 +103,7 @@ pub trait HashDB : AsHashDB { | |||
| /// assert_eq!(m.get(key).unwrap(), d); | |||
| /// } | |||
| /// ``` | |||
| fn remove(&mut self, key: &H256) { self.kill(key) } | |||
| fn remove(&mut self, key: &H256); | |||
There was a problem hiding this comment.
This file is incorrectly formatted. Use tabs instead of spaces
rphmeier
added
A4-gotissues 💥
rphmeier
added
A8-looksgood 🦄
|
been waiting for this for a while. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.