This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Reserved peers rpc API #1360
Merged
Reserved peers rpc API #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A current shortcoming: stopping and starting the network will erase reserved peers not specified at startup and non-reserved peer mode. |
Closed
arkpar
added
A8-looksgood 🦄
rphmeier
added
A0-pleasereview 🤓
rphmeier
force-pushed
the
reserved-peers-rpc
branch
from
b13bb33
to
3696f57
Compare
rphmeier
added
A8-looksgood 🦄
|
(testing on pi.parity.io shows that this works as expected) |
|
could you file the "shortcoming" as an issue? |
|
@gavofyork There is a tracking issue open here: https://github.com/ethcore/parity/issues/1336 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears to work, but can't test whether no reserved nodes will be accepted without deploying to one of our nodes and testing for a few hours.
Also need some reliable nodes to test as reserved nodes -- I've been using the bootnodes, but only 1 of them ever reliably connects.
Does not include the suggested "passive" API, as that is more involved with the sync code and is better saved for a later PR.