This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Network start/stop #1313
Merged
Network start/stop #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Should be used to convert object to io delegate. | ||
| fn to_delegate(self) -> IoDelegate<Self> { | ||
| let mut delegate = IoDelegate::new(Arc::new(self)); | ||
| delegate.add_method("net_version", Net::version); | ||
| delegate.add_method("net_peerCount", Net::peer_count); | ||
| delegate.add_method("net_listening", Net::is_listening); | ||
| delegate.add_method("net_start", Net::start_network); |
There was a problem hiding this comment.
It will be possible to enable/disable network for a potential attacker (browsing malicious website with Flash enabled) are we ok with that?
If not we should put the API to separate trait, in future it could require confirmation using Trusted Signer.
There was a problem hiding this comment.
agree - there's no need to have these as RPC functions right now.
| /// Start network command. | ||
| StartNetwork, | ||
| /// Stop network command. | ||
| StopNetwork, | ||
| } | ||
|
|
||
| /// IO Message type used for Network service | ||
| pub type NetSyncMessage = NetworkIoMessage<SyncMessage>; |
There was a problem hiding this comment.
Should probably not be call NetSyncMessage, but something more generic...
There was a problem hiding this comment.
Will do later, this requires refactoring anyway
|
looks pretty good. |
gavofyork
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.