Exposing RPC over Signer WebSockets #1167
Conversation
Conflicts: rpc/src/v1/types/bytes.rs
Conflicts: parity/signer.rs signer/Cargo.toml signer/src/lib.rs signer/src/ws_server/mod.rs
tomusdrw
added
A0-pleasereview 🤓
Conflicts: dapps/src/lib.rs parity/main.rs parity/signer.rs signer/Cargo.toml signer/src/lib.rs
tomusdrw
removed
the
A1-onice 🌨
arkpar
added
A8-looksgood 🦄
| handler: Arc<IoHandler>, | ||
| } | ||
|
|
||
| impl Default for ServerBuilder { |
There was a problem hiding this comment.
is this default impl used?
There was a problem hiding this comment.
Nope, but it's recommended by rust-clippy to have one if you have a no-argument pub fn new() -> Self.
I prefer to use ServerBuilder::new() then ServerBuilder::default(), but like to keep clippy happy as well :)
Do you think we should just use default()?
There was a problem hiding this comment.
ah, i didn't realize that it was for clippy's benefit. I guess intuitively i would probably have it the other way -- have new()call default() rather than the other way around, but that's definitely just a personal preference.
There was a problem hiding this comment.
think there's something to be said for making default the canonical means of naming/refering to parameter-less construction functions; it's got a stronger semantic notation given it's a trait rather than Just Another Consistently Named Function.
There was a problem hiding this comment.
Default implementation will be removed in future PRs anyway.
No description provided.