This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Support "earliest" and specific block parameters in RPC where possible #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn nonce(&self, address: &Address, id: BlockID) -> Option<U256>; | ||
|
|
||
| /// Get address nonce at the latest block's state. | ||
| fn nonce_latest(&self, address: &Address) -> U256 { |
There was a problem hiding this comment.
I think the most common case is to use nonce_latest which should stay nonce imho.
Can we have nonce_at_block or sth like this instead?
There was a problem hiding this comment.
That is how I had it initially, but I found that the breakage caused by the change in signature was actually very small in reality. State::nonce and Miner::nonce are unchanged, and this is where most code actually looks for nonces.
rphmeier
force-pushed
the
rpc-earliest-specific
branch
from
836e2eb
to
6c5c0ad
Compare
|
|
||
| fn make_unsupported_err() -> Error { | ||
| Error { | ||
| code: ErrorCode::ServerError(UNSUPPORTED_REQUEST_CODE), |
tomusdrw
added
A5-grumble 🔥
rphmeier
force-pushed
the
rpc-earliest-specific
branch
from
6c5c0ad
to
cd7153f
Compare
with modus ponens panickers
rphmeier
force-pushed
the
rpc-earliest-specific
branch
from
cd7153f
to
a272f85
Compare
tomusdrw
added
A8-looksgood 🦄
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may not be possible whenever the database does any kind of pruning.