Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

New syncing part 1: Block collection #1088

Merged
merged 2 commits into from
May 16, 2016
Merged

New syncing part 1: Block collection #1088

merged 2 commits into from
May 16, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented May 16, 2016

No description provided.

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label May 16, 2016
self.heads = hashes;
}

/// Insert a set oh headers into collection and advance subchain head pointers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh -> of

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 16, 2016
@gavofyork
Copy link
Contributor

minor style grumbles. haven't done a deep check of the logic but tests look good.

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels May 16, 2016
@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels May 16, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 16, 2016
@NikVolf NikVolf merged commit d249918 into master May 16, 2016
@debris debris deleted the sync-hashes-collection branch June 20, 2016 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants