Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Subdomains support in content server (webapps server). #1082

Merged
merged 4 commits into from
May 16, 2016

Conversation

tomusdrw
Copy link
Collaborator

No description provided.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label May 13, 2016
return "DIRECT";
}}
"#,
DAPPS_DOMAIN, path.host, path.port);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one DAPPS_DOMAIN? would probably be sensible to have a .parity domain for inbuilt-parity stuff (which would use parity-specific RPCs) and .dapp domain for theoretically standardised, cross-implementation stuff.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be easily extended to support more "domains", but we can still use addresses like:
http://status.parity.dapp or http://myoracle.ethcore.dapp

Copy link
Contributor

@gavofyork gavofyork May 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah; i'm taking direction from the classic about: (and newer chrome:) protocols which don't try to map over http: but rather use a different namespace.

i would reserve the .dapp domain for pages/packages which are, in principle, independent of parity. .parity could be used for our packages which are built in (i.e. all of them at present).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the domain to .parity (since we only have built-in dapps).
Will prepare multi-domain support in separte PR.

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 14, 2016
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels May 16, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 16, 2016
@gavofyork gavofyork merged commit 9301963 into master May 16, 2016
@gavofyork gavofyork deleted the content-server branch May 16, 2016 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants