Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

trace_filter #8070

Closed
alesl opened this issue Mar 7, 2018 · 0 comments · Fixed by #8098
Closed

trace_filter #8070

alesl opened this issue Mar 7, 2018 · 0 comments · Fixed by #8098
Labels
F2-bug 🐞 The client fails to follow expected behavior. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone
1.11 Prosperity

Comments

@alesl
Copy link

alesl commented Mar 7, 2018

I'm running:

  • Which Parity version?: v1.9.3-beta-804ddfe31-20180219
  • Which operating system?: Linux
  • How installed?: installer
  • Are you fully synchronized?: yes
  • Which network are you connected to?: ethereum
  • Did you try to restart the node?: yes

It seems to me that there is a minor issue with trace_filter rpc method.
If only fromAddress is provided, api also returns unrelated block reward calls.
If I understand correctly, the issue is in filter.rs.
Empty to_address shouldn't match, eg:

!self.to_address.matches_all() && self.to_address.matches(&reward.author)
@debris debris added F2-bug 🐞 The client fails to follow expected behavior. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels Mar 11, 2018
debris added a commit that referenced this issue Mar 13, 2018
@debris
fix trace filter returning returning unrelated reward calls, closes #…
d867b64 
…8070
@debris debris mentioned this issue Mar 13, 2018
Merged
debris added a commit that referenced this issue Mar 14, 2018
@debris
fix trace filter returning returning unrelated reward calls, closes #…
0e548ce 
…8070 (#8098)
andresilva pushed a commit that referenced this issue Mar 16, 2018
@debris @andresilva
fix trace filter returning returning unrelated reward calls, closes #…
9aa52f7 
…8070 (#8098)
andresilva pushed a commit that referenced this issue Mar 19, 2018
@debris @andresilva
fix trace filter returning returning unrelated reward calls, closes #…
b1fb9fa 
…8070 (#8098)
tomusdrw pushed a commit that referenced this issue Mar 19, 2018
@andresilva @tomusdrw
[Beta] Backports (#8136)
610f6f1 
* Support parity protocol. (#8035)

* updater: apply exponential backoff after download failure (#8059)

* updater: apply exponential backoff after download failure

* updater: reset backoff on new release

* Max code size on Kovan (#8067)

* Enable code size limit on kovan

* Fix formatting.

* Limit incoming connections.  (#8060)

* Limit ingress connections
* Optimized handshakes logging

* WASM libraries bump (#7970)

* update wasmi, parity-wasm, wasm-utils to latest version

* Update to new wasmi & error handling

* also utilize new stack limiter

* fix typo

* replace dependency url

* Cargo.lock update

* add some dos protection (#8084)

* revert removing blooms (#8066)

* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs

* more dos protection (#8104)

* Const time comparison (#8113)

* Use `subtle::slices_equal` for constant time comparison.

Also update the existing version of subtle in `ethcrypto` from
0.1 to 0.5

* Test specifically for InvalidPassword error.

* fix trace filter returning returning unrelated reward calls, closes #8070 (#8098)

* network: init discovery using healthy nodes (#8061)

* network: init discovery using healthy nodes

* network: fix style grumble

* network: fix typo

* Postpone Kovan hard fork (#8137)

* ethcore: postpone Kovan hard fork

* util: update version fork metadata

* Disable UI by default. (#8105)

* dapps: update parity-ui dependencies (#8160)
@5chdn 5chdn added this to the 1.11 milestone Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F2-bug 🐞 The client fails to follow expected behavior. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging a pull request may close this issue.

fix trace filter returning unrelated reward calls, openethereum/parity-ethereum
3 participants
@alesl @debris @5chdn